Claudio Grasso commented on a discussion on LICENSE.md: 
https://gitlab.rtems.org/rtems/pkg/rtems-lwip/-/merge_requests/37#note_142816

 > -*/
 >  
 > +*/
 >  
 >  defs license
 >  ============
 > +
 >  /*
 > +
 >  * Redistribution and use in source and binary forms, with or without
 >  * modification, are permitted provided that the following conditions
 >  * are met:
 >  * 1. Redistributions of source code must retain the above copyright
 >  * notice, this list of conditions and the following disclaimer.
 > - * 2. Redistributions in binary form must reproduce the above copyright
 > +* 1. Redistributions in binary form must reproduce the above copyright

Hi Kinsey,

I have completely restructured the pull request. After reviewing the previous 
commit history, I found several inconsistencies—including the unrelated changes 
to README.md and the accidental modification of the **LICENSE.md** numbering—so 
I decided to rebuild the branch from scratch to ensure a pristine state.

The new history consists of exactly two clean commits:

1. **Import stm32h7 driver**: A pristine import verified against the upstream 
STM32CubeH7 repository (plus necessary 

   LICENSE.md/**README.md** updates).
   * **Integrity Verification**: I verified the integrity of these files by 
comparing their **MD5 checksums** against the upstream GitHub repository to 
ensure they are byte-for-byte identical.
   * **Corrected License**: The numbering issue in **LICENSE.md** (changing 2. 
to 1.) was a mistake in the previous history. By rebuilding from the pristine 
upstream file, this is now corrected.
2. **Adapt stm32h7 driver**: Contains all RTEMS-specific adaptations applied as 
additive patches with **`#ifdef __rtems__`** guards.

I have also addressed your other specific feedback:

* **Restored  wscript**: Reverted unnecessary logic changes; it now uses the 
default upstream configuration.
* **Cleaned Debug Code**: Removed custom **`TRACE_PRINTF`** macros and 
excessive debug output.
* **Reference Branch**: Ensured no unrelated files (e.g., Zynq driver changes) 
are included.

The branch **`pr/stm32h7-driver`** has been force-pushed, confirmed to build 
cleanly, and tested on hardware.

Kind regards,

Claudio

-- 
View it on GitLab: 
https://gitlab.rtems.org/rtems/pkg/rtems-lwip/-/merge_requests/37#note_142816
You're receiving this email because of your account on gitlab.rtems.org.


_______________________________________________
bugs mailing list
[email protected]
http://lists.rtems.org/mailman/listinfo/bugs

Reply via email to