SHIVAM DEOLANKAR commented: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1111#note_144782 I consolidated the APIC definitions by removing the pc386 header (`bsps/i386/include/bsp/apic.h`) and making pc386 include `<apic.h>`, which resolves to `bsps/x86_64/amd64/include/apic.h`. The pc386 code was updated to use the same array-based LAPIC access pattern as x86_64, replacing pointer arithmetic and `IMPS_LAPIC_READ/WRITE` with: amd64_lapic_base\[LAPIC_REGISTER\_\*\] Old macros (`LAPIC_ID`, `LAPIC_EOI`, `LAPIC_SPIV`, `LAPIC_ICR`) were replaced with the x86_64 definitions (`LAPIC_REGISTER_*`). Verification performed: * Confirmed the pc386 APIC header is removed. * Confirmed pc386 includes `<apic.h>`. * Verified pc386 uses `amd64_lapic_base[LAPIC_REGISTER_*]`. * Verified `IMPS_LAPIC_*` macros are no longer used in pc386 code. * Built and tested the `pc386` BSP successfully. The screenshot shows these verification checks (`git grep` results) confirming the new access pattern and absence of the old macros. {width=900 height=449} -- View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1111#note_144782 You're receiving this email because of your account on gitlab.rtems.org.
_______________________________________________ bugs mailing list [email protected] http://lists.rtems.org/mailman/listinfo/bugs
