彤彤 李 commented on a discussion: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1250#note_150584


Thanks for the review. I understand the main issue now: the implementation 
should be based directly on the imported FreeBSD code, rather than using the 
FreeBSD import only as reference material.

I will rework this draft MR accordingly:

* re-import the FreeBSD sources from the official upstream at 
`https://cgit.freebsd.org/src/`, using a recent release source
* keep the `contrib/` import as unchanged upstream reference code
* base the `libcsupport/src` passwd/group implementation directly on the 
FreeBSD sources
* keep RTEMS-specific changes small and guarded where appropriate
* keep the default `/etc/passwd` and `/etc/group` creation logic in a separate 
RTEMS helper file
* address the review comments about license headers, prototypes coming from 
headers, `RTEMS_ALIGN_UP`, comments for helper functions, and style issues
* handle the POSIX Users Guide documentation in a separate MR to `rtems-docs`

I will leave the inline threads open for now and resolve them after pushing the 
reworked series.

-- 
View it on GitLab: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1250#note_150584
You're receiving this email because of your account on gitlab.rtems.org.


_______________________________________________
bugs mailing list
[email protected]
http://lists.rtems.org/mailman/listinfo/bugs

Reply via email to