Gedare Bloom started a new discussion on cpukit/dhrl/dhrl.c: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1193#note_150589

 > +    "Calibration Complete. Hardware routing bit locked: %u\n",
 > +    best_bit
 > +  );
 > +}
 > +
 > +/* Initialization */
 > +rtems_status_code dhrl_init(
 > +  const dhrl_config  *config,
 > +  uint32_t            core_a,
 > +  uint32_t            core_b,
 > +  rtems_task_priority priority
 > +)
 > +{
 > +  rtems_status_code    sc;
 > +  cpu_set_t            cpuset;
 > +  struct dhrl_control *ctx = &dhrl_instance;

I would embed the `ctx` into the config structure. It can be done as a `void *` 
if needed. This would provide better encapsulation. It would also allow 
removing the global variable by using malloc instead.

-- 
View it on GitLab: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1193#note_150589
You're receiving this email because of your account on gitlab.rtems.org.


_______________________________________________
bugs mailing list
[email protected]
http://lists.rtems.org/mailman/listinfo/bugs

Reply via email to