Yang Zhang commented on a discussion on bsps/shared/dev/gpio/gpio-support.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1281#note_151776 > return RTEMS_UNSATISFIED; > } > > + group->digital_inputs = NULL; > + group->digital_outputs = NULL; > + group->bsp_speficifc_pins = NULL; > + > group->input_count = group_definition->input_count; > > if ( group->input_count > 0 ) { > group->digital_inputs = > (uint32_t *) malloc(group->input_count * sizeof(uint32_t)); > > + if ( group->digital_inputs == NULL ) { > + sc = RTEMS_NO_MEMORY; > + goto failed_alloc; Thanks for the review. I have updated the patch to remove the goto pattern. The cleanup logic has been extracted into a static void release_group_allocations() helper function, which is now called directly upon failure. I also fixed all typos where specific was misspelled as speficifc throughout this .c file. Please take another look. -- View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1281#note_151776 You're receiving this email because of your account on gitlab.rtems.org.
_______________________________________________ bugs mailing list [email protected] http://lists.rtems.org/mailman/listinfo/bugs
