Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1156 was reviewed by Joel Sherrill
-- Joel Sherrill started a new discussion on bsps/arm/stm32h7/start/stm32h7-hal.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1156#note_152308 > > + /* Prevent NULL pointer dereference */ > + if (enr == NULL) { This likely should be an _Assert() because it is a design error. -- Joel Sherrill started a new discussion on bsps/arm/stm32h7/start/stm32h7-hal.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1156#note_152309 > > + /* Prevent NULL pointer dereference */ > + if (enr == NULL) { This likely should be an _Assert() because it is a design error. -- Joel Sherrill started a new discussion on bsps/arm/stm32h7/start/stm32h7-hal.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1156#note_152310 > enable_bit = stm32h7_clk_low_power[index].enable_bit; > > + if (enr == NULL) { This likely should be an _Assert() because it is a design error. -- Joel Sherrill started a new discussion on bsps/arm/stm32h7/start/stm32h7-hal.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1156#note_152311 > stm32h7_module_index index; > > + if (config == NULL) { This likely should be an _Assert() because it is a design error. -- Joel Sherrill started a new discussion on bsps/arm/stm32h7/start/stm32h7-hal.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1156#note_152312 > while ((regs->ISR & USART_ISR_TXE_TXFNF) == 0) { > - /* Wait */ > + if (timeout-- == 0) { How do we know how long the timeout actually lasts? -- View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1156 You're receiving this email because of your account on gitlab.rtems.org.
_______________________________________________ bugs mailing list [email protected] http://lists.rtems.org/mailman/listinfo/bugs
