Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1343 was reviewed by Vijay Banerjee
-- Vijay Banerjee started a new discussion on cpukit/score/src/processormaskcopy.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1343#note_154007 > > while ( dst_size > 0 && src_size > 0 ) { > unsigned long bits = *src; This makes it a signed to unsigned conversion. Probably this is okay for the bit operations here, but I'm curious why the processor mask arguments are signed. Should we make the types consistent in the body if the sign changed is needed in the function params? -- Vijay Banerjee started a new discussion on cpukit/include/rtems/score/processormaskimpl.h: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1343#note_154008 > { > return _Processor_mask_Copy( > &dst->__bits[ 0 ], Maybe I am missing something, but looking at the cpuset.h and _cpuset.h, it looks like __bits[] is unsigned long, defined with __BITSET_DEFINE(). Is there a reason to change the parameters to signed? There is also a potential pointer mismatch here? -- View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1343 You're receiving this email because of your account on gitlab.rtems.org. Unsubscribe from this thread: https://gitlab.rtems.org/-/sent_notifications/4-8z6kxi4q2j6nf568cke3b5tmu-1d/unsubscribe | Manage all notifications: https://gitlab.rtems.org/-/profile/notifications | Help: https://gitlab.rtems.org/help
_______________________________________________ bugs mailing list [email protected] http://lists.rtems.org/mailman/listinfo/bugs
