Pavel Pisa commented: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1365#note_155264 Thanks for checking and fixing the code. I have done review through commits. When the comments are updated according to @opticron suggestion then I agree with all the changes. The most of them, mainly related to the error setup, should be checked in SJA1000 code as well. I can add that to !1364 (I would sqush it probaly to single commit for SJA1000 when details are provided there) or @michallenc can check it or you can propose these changes for SJA1000. -- View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1365#note_155264 You're receiving this email because of your account on gitlab.rtems.org. Unsubscribe from this thread: https://gitlab.rtems.org/-/sent_notifications/4-caaqyg46tpy28ht2u7u4s0ew8-1d/unsubscribe | Manage all notifications: https://gitlab.rtems.org/-/profile/notifications | Help: https://gitlab.rtems.org/help
_______________________________________________ bugs mailing list [email protected] http://lists.rtems.org/mailman/listinfo/bugs
