Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1384 was reviewed by Chris Johns
-- Chris Johns started a new discussion on bsps/powerpc/motorola_powerpc/bootloader/mm.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1384#note_156353 > for(i=0; i<res->ActualNumMemSegs; i++) { > - if (res->Segs[i].Usage & flags > + if (res->Segs[i].PageCount Please make the comparison explicit so: ``` if (res->Segs[i].PageCount != 0 ``` -- Chris Johns started a new discussion on bsps/powerpc/motorola_powerpc/bootloader/mm.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1384#note_156354 > for (i=0; i<res->ActualNumMemSegs; i++) { > - if ( (res->Segs[i].BasePage+res->Segs[i].PageCount > + if ( res->Segs[i].PageCount And again here. -- Chris Johns started a new discussion on bsps/powerpc/shared/console/uart.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1384#note_156355 > +#else > +#define UART_REG_OFF(reg) (reg) > +#endif Why is this repeated here and in `console.ini`? -- View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1384 You're receiving this email because of your account on gitlab.rtems.org. Unsubscribe from this thread: https://gitlab.rtems.org/-/sent_notifications/4-6nzkqxw8b7hpl2u4p2jck862u-1d/unsubscribe | Manage all notifications: https://gitlab.rtems.org/-/profile/notifications | Help: https://gitlab.rtems.org/help
_______________________________________________ bugs mailing list [email protected] http://lists.rtems.org/mailman/listinfo/bugs
