Vijay Banerjee commented on a discussion on bsps/powerpc/shared/console/uart.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1384#note_156416 > * different just rewrite these macros > */ > > +/* The MVME5100's memory-mapped TL16C550 places its registers on 16-byte > + * boundaries; other boards use byte-adjacent registers. */ > +#ifdef mot_ppc_mvme5100 > +#define UART_REG_OFF(reg) ((reg) << 4) > +#else > +#define UART_REG_OFF(reg) (reg) > +#endif I have now added a generic version of this in the bsp.h to avoid repeated change. This is still a work around. The cleaner solution would be to separate all the different bsp variants into their own separate modules and bsp.h files. I will work on cleaning motorola_powerpc next, and turn each bsp into their separate module and put the shared codes into shared/. After the cleanup, I also plan to switch the console driver to the ns16550 driver in RTEMS instead of this inline console implementation. -- View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1384#note_156416 You're receiving this email because of your account on gitlab.rtems.org. Unsubscribe from this thread: https://gitlab.rtems.org/-/sent_notifications/4-dlbtnva3nv2nqhwvakqmg5wj2-1d/unsubscribe | Manage all notifications: https://gitlab.rtems.org/-/profile/notifications | Help: https://gitlab.rtems.org/help
_______________________________________________ bugs mailing list [email protected] http://lists.rtems.org/mailman/listinfo/bugs
