Sam Price commented on a discussion: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1444#note_157871 I was running `gcc -fanalyze` and wanted these bugs to be fixed, being from an upstream source I went there first looking for fixes. This is not a 1-1 PR from upstream. RTEMS had the extra pattern of ``` if (m) free(resolved); ``` Not being a submodule I don't know how to cherry-pick the upstream commits. I agree the whole upstream commits should be audited. Perhaps you store the hash of the original port in a comment at the top of the file, or a change log? That would allow for periodic audits of upstream sources? Possibly scripted in some way? -- View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1444#note_157871 You're receiving this email because of your account on gitlab.rtems.org. Unsubscribe from this thread: https://gitlab.rtems.org/-/sent_notifications/5-az7679dxb7q07np9rb12vulro-1d/unsubscribe | Manage all notifications: https://gitlab.rtems.org/-/profile/notifications | Help: https://gitlab.rtems.org/help
_______________________________________________ bugs mailing list [email protected] http://lists.rtems.org/mailman/listinfo/bugs
