Sebastian Huber created a merge request: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1507

Project:Branches: sebhub/rtems:up/build-format to rtems/rtos/rtems:main
Author: Sebastian Huber

## Summary

Issue #5783: The build items follow no common format

Commits:

- `bsps/microblaze: Define the UART IRQ in decimal`
- `bsps: Define the PL011 FIFO depth in decimal`
- `bsps/aarch64: Define the MMU page count in decimal`
- `build: Sort the source lists`
- `build: Sort the validation source lists`
- `build: Sort the attributes of the items`
- `build: Do not indent the lists`
- `build: Remove trailing white space`
- `build: Format the integers of the options`
- `build: Quote strings like the formatter`
- `build: Write the empty action values as null`
- `build: Fold the long plain scalars`

The branch formats the build items as `specverify --format-items
--do-not-indent-lists spec` does with the schema of `specware` 1.3.2.
After the branch the command changes no item. Each commit holds one
kind of change, so a reviewer can check each one on its own.
`git diff -w` shows nothing for the list indentation commit.

Only five commits change the content. The first three set the format
of three options to decimal. This changes the spelling of their defines
in `bspopts.h` and not the value. The two sort commits change the order
of the source files. The validation test cases sit in a linker set
which the linker sorts by name, so the order of the test cases stays.
The parsed items of the other seven commits are equal before and after.

A later formatting pass may drop the option `--do-not-indent-lists`.
The list items would then move two spaces to the right of their key.

The branch was built for one or more BSPs of each architecture with the
validation tests enabled. `powerpc/mvme2100` fails to compile
`tx-call-within-isr.c` because `tm27.h` is missing. It fails in the
same way without the branch.

## AI Details
<!-- Make sure you have read our statement at 
https://www.rtems.org/generative-ai/ -->

### Prompt used

None as a single prompt.  The work was done in an interactive Claude Code
session on the RTEMS tree.  The task was to run the test suites of the
simulator BSPs, diagnose every failure and fix the cause.  Each change was
directed and reviewed.

### AI model used

Claude Opus 5 (claude-opus-5), through Claude Code.

### How AI was used for the contribution

- [ ] Formatting
- [ ] Test creation.
- [x] Code comments.
- [ ] The entire contribution was generated using AI
- [ ] AI code completion such as Copilot in VSCode.

The diagnosis and the implementation were produced in that session under my
direction, and the commit messages were drafted there.

### Access

I have not used a product which claims copyright in its output, and I have
legitimate access to the one I used.

-- 
View it on GitLab: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1507
You're receiving this email because of your account on gitlab.rtems.org. 
Unsubscribe from this thread: 
https://gitlab.rtems.org/-/namespace/49/sent_notifications/5-d6pcd4lh97ghrtp185oj3yphi-1d/unsubscribe
 | Manage all notifications: https://gitlab.rtems.org/-/profile/notifications | 
Help: https://gitlab.rtems.org/help


_______________________________________________
bugs mailing list
[email protected]
http://lists.rtems.org/mailman/listinfo/bugs

Reply via email to