Christian Mauderer commented: https://gitlab.rtems.org/rtems/pkg/rtems-libbsd/-/merge_requests/163#note_160195 I'm completely fine with the overall code of the patch. Just a question regarding the organization: The `CONTRIBUTING.md` still suggests to first import the code in one patch and then add changes in a separate one: https://gitlab.rtems.org/rtems/pkg/rtems-libbsd/-/blob/7-freebsd-14/CONTRIBUTING.rst?ref_type=heads&plain=1#L269 Usually I follow that suggestions. That makes it easy to review what has been changed to adapt something to RTEMS like in these patches (disclaimer: I mentored the GSoC project that added these so of course they follow that pattern too): https://gitlab.rtems.org/rtems/pkg/rtems-libbsd/-/commit/c89f1210a7f96e2ff82ec0b0b2303b21720105ba https://gitlab.rtems.org/rtems/pkg/rtems-libbsd/-/commit/fdd9fa734c4b32b4dd86e053878328dcfdfec735 Would it make sense to split your patch to match that pattern? -- View it on GitLab: https://gitlab.rtems.org/rtems/pkg/rtems-libbsd/-/merge_requests/163#note_160195 You're receiving this email because of your account on gitlab.rtems.org. Unsubscribe from this thread: https://gitlab.rtems.org/-/namespace/20/sent_notifications/5-eopsde6jogpymzhones87lsze-k/unsubscribe | Manage all notifications: https://gitlab.rtems.org/-/profile/notifications | Help: https://gitlab.rtems.org/help
_______________________________________________ bugs mailing list [email protected] http://lists.rtems.org/mailman/listinfo/bugs
