Gedare Bloom started a new discussion on 
bsps/riscv/include/bsp/riscv-fdt-irq.h: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1520#note_160964

 > + *   indicates a processor without a CLINT index.
 > + */
 > +static inline uint32_t riscv_clint_get_index( uint32_t cpu_index )
 > +{
 > +  if ( cpu_index >= RISCV_FDT_PROCESSOR_MAXIMUM ) {
 > +    return UINT32_MAX;
 > +  }
 > +
 > +  return riscv_fdt_clint_index[ cpu_index ];
 > +}
 > +#endif
 > +
 > +/**
 > + * @brief This define indicates that the system may have no PLIC.
 > + */
 > +#define RISCV_PLIC_MAY_BE_ABSENT

should it be `MAY_BE_INVALID` here or use `MAY_BE_ABSENT` in the other two?

Should these defines be consolidated instead of spread among the helper 
functions?

-- 
View it on GitLab: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1520#note_160964
You're receiving this email because of your account on gitlab.rtems.org. 
Unsubscribe from this thread: 
https://gitlab.rtems.org/-/namespace/49/sent_notifications/6-06sravpcnw5vqezqz4qhp0rsn-1d/unsubscribe
 | Manage all notifications: https://gitlab.rtems.org/-/profile/notifications | 
Help: https://gitlab.rtems.org/help


_______________________________________________
bugs mailing list
[email protected]
http://lists.rtems.org/mailman/listinfo/bugs

Reply via email to