Sebastian Huber commented on a discussion: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1527#note_161047 Sorry, I overlooked your MR. I also really don't know why this generally useful change is blocked. !1043 and !1531 have the same goal. On main (10e3cf67d6e) with clang-format 22.1.8, 454 sources outside the !1043 ignore list need a reformat. With !1531 the count is 293. The patterns `testsuites/ada` and `testsuites/benchmarks` in !1043 lack `/**` and match no file. !1043 also misses the generated image headers of fdt01 and fsdosfsname01, libi2c and the unformatted headers in cpukit/include/rtems. !1531 misses cpukit/libmisc/rtems-fdt. I will add it. The two merge requests treat the BSPs in opposite ways: | | !1043 | !1531 | | --- | --- | --- | | Method | One line per ignored BSP directory | `bsps/**`, and an empty `.clang-format-ignore` in each formatted directory | | Default for a new BSP directory | Formatted | Ignored | | Turn on a formatted directory | Delete a line | Add a file in that directory | | Where to read the state | One file | The top file and the files below `bsps/` | | Patterns below a formatted directory | The top file applies | A file in a subdirectory replaces the top file. Every pattern needed below it must be repeated there. | | `bsps/riscv/noel` | Formatted. One of its 6 sources needs a reformat. | Ignored | | `bsps/shared/grlib` | Ignored | Formatted. One of its 67 sources needs a reformat. | In !1043, a new BSP directory is formatted with no review of its code. In !1531, nobody has to edit the ignore list for a new BSP until it follows the style. Today no `contrib` code lies below the three formatted directories of !1531. So the replacement rule costs nothing for now. I propose to continue with !1531 and to close !1043, or the reverse if you prefer your layout. -- View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1527#note_161047 You're receiving this email because of your account on gitlab.rtems.org. Unsubscribe from this thread: https://gitlab.rtems.org/-/namespace/49/sent_notifications/6-9mmvvh4a3ri83xbi5lc7pdmnb-1d/unsubscribe | Manage all notifications: https://gitlab.rtems.org/-/profile/notifications | Help: https://gitlab.rtems.org/help
_______________________________________________ bugs mailing list [email protected] http://lists.rtems.org/mailman/listinfo/bugs
