Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1551 was reviewed by Joel Sherrill
-- Joel Sherrill started a new discussion: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1551#note_161868 I think the code is OK. I am adding two cleanups so we can track them separately. This first is to change the commit which says "documentation". It is a spelling error in the Doxygen comments. When I saw documentation, I thought it was for the rtems-docs repo. -- Joel Sherrill started a new discussion: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1551#note_161869 Second comment which @opticron, @gedare, or @kiwichris can hopefully confirm my request. The feature macro HEAP_PROTECTION pollutes the general name space. I think it should be RTEMS_HEAP_PROTECTION. If they agree, resolve this comment by creating an issue and fix that in a separate MR. -- View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1551 You're receiving this email because of your account on gitlab.rtems.org. Unsubscribe from this thread: https://gitlab.rtems.org/-/namespace/49/sent_notifications/6-9mqur2yfny038ppiamh4c2coj-1d/unsubscribe | Manage all notifications: https://gitlab.rtems.org/-/profile/notifications | Help: https://gitlab.rtems.org/help
_______________________________________________ bugs mailing list [email protected] http://lists.rtems.org/mailman/listinfo/bugs
