Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1563 was reviewed by Vijay Banerjee
-- Vijay Banerjee started a new discussion on cpukit/include/rtems/shellconfig.h: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1563#note_161982 > - extern rtems_shell_cmd_t rtems_shell_NETSTATS_Command; > - extern rtems_shell_cmd_t rtems_shell_PING_Command; > -#endif This will almost certainly break some applications using net-legacy. The best way to remove this is to move these into another header inside `rtems-net-legacy`. Not sure if there is a common header like that and I would discourage adding new header files just for net-legacy shell because applications would need to include it. This one one of the primary reasons it was left in here. If you can find some common header to move these too, it might be finally removed from here :smile: -- Vijay Banerjee started a new discussion on testsuites/libtests/dl08/dl08.scn: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1563#note_161983 > *** TEST STATE: EXPECTED_PASS > -*** TEST BUILD: RTEMS_NETWORKING RTEMS_POSIX_API > +*** TEST BUILD: RTEMS_POSIX_API Are these scn files saying something different than what the tests are printing today? -- Vijay Banerjee started a new discussion on testsuites/libtests/record01/init.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1563#note_161984 > }; > > -#ifdef RTEMS_NETWORKING This also looks like one of the things that needs to be moved to rtems-net-legacy first instead of just deleting from here outright. there's a testsuite inside `rtems-net-legacy` just for that ;) -- View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1563 You're receiving this email because of your account on gitlab.rtems.org. Unsubscribe from this thread: https://gitlab.rtems.org/-/namespace/49/sent_notifications/6-7oc253jyfsb13q36irikmhaiw-1d/unsubscribe | Manage all notifications: https://gitlab.rtems.org/-/profile/notifications | Help: https://gitlab.rtems.org/help
_______________________________________________ bugs mailing list [email protected] http://lists.rtems.org/mailman/listinfo/bugs
