Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1568 was reviewed by Christian Mauderer
-- Christian Mauderer started a new discussion on bsps/powerpc/mvme3100/include/bsp/VMEConfig.h: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1568#note_162150 > -#define _VME_A24_ON_PCI 0xcf000000 > -#define _VME_A16_ON_PCI 0xcfff0000 > +#define _VME_A32_WIN0_ON_PCI 0xa0000000 You replaced most magic numbers with options. You changed the position, so I assume it can be configured. So why didn't you replace that magic number with a BSP option too? -- Christian Mauderer started a new discussion: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1568#note_162151 It seems that there are a lot of duplicated `optvme*.yml` files to define the values for the various BSPs. Would there be a disadvantage to place them one level higher in the `powerpc` group and re-use them for all BSPs? Different default values for different BSPs can be created with multiple `-enabled-by: some-bsp` entries. That's done in other BSPs too. For example for [BSP_ARM_A9MPCORE_PERIPHCLK in opta9periphclk.yml](https://gitlab.rtems.org/rtems/rtos/rtems/-/blob/main/spec/build/bsps/arm/opta9periphclk.yml?ref_type=heads) -- View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1568 You're receiving this email because of your account on gitlab.rtems.org. Unsubscribe from this thread: https://gitlab.rtems.org/-/namespace/49/sent_notifications/6-a9j2v2dd6t2ied0yzla1pc9q8-1d/unsubscribe | Manage all notifications: https://gitlab.rtems.org/-/profile/notifications | Help: https://gitlab.rtems.org/help
_______________________________________________ bugs mailing list [email protected] http://lists.rtems.org/mailman/listinfo/bugs
