I don't see your name on the SCA list:

  https://sca.dev.java.net/CA_signatories.htm

Signing the SCA is required before I can integrate your change:

  http://www.sun.com/software/opensource/sca.pdf

Legal red tape. :^(

The changes look good to me, simple, small, and I think should work fine.

-kto

Ben Cheng wrote:
On Nov 28, 2007 10:47 AM, Kelly O'Hair <[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>> wrote:


    If your adventure is to figure out how to build 32bit on a 64bit
    system, please keep track
    of what you had to do and we can document it, and have fun. ;^)


I have a four-file patch that enables me to do 32-bit build on 64-bit linux machines (where 32-bit libraries are installed) now. I don't need to specify ARCH explicitly on the build command line. Instead, I rely on saying ARCH_DATA_MODEL=32 to override the auto-detected ARCH value in several makefiles.

Thanks,
-Ben

--------------------------------------------------------------------------

==== control/make/jprt.config ====
179c179,184
<       linux_arch=amd64
---
 >         # LOCALPATCH
 >         if [ "${ARCH_DATA_MODEL}" = 64 ] ; then
 >           linux_arch=amd64
 >         else
 >           linux_arch=i586
 >         fi
==== control/make/make/jprt.config ====
179c179,184
<       linux_arch=amd64
---
 >         # LOCALPATCH
 >         if [ "${ARCH_DATA_MODEL}" = 64 ] ; then
 >           linux_arch=amd64
 >         else
 >           linux_arch=i586
 >         fi
==== corba/make/common/shared/Platform.gmk ====
217c217,219
<     # i586 is 32-bit, amd64 is 64-bit
---
 >     # LOCALPATCH
> # i586 is 32-bit, amd64 is 64-bit, unless ARCH_DATA_MODEL is explicitly set
 >     # as 32 and ARCH will be demoted to i586
223a226,230
 >     else
 >       ifeq ($(ARCH_DATA_MODEL), 32)
 >       ARCH=i586
 >       ARCH_FAMILY := $(ARCH)
 >       endif
==== jdk/make/common/shared/Platform.gmk ====
226c226,228
<     # i586 is 32-bit, amd64 is 64-bit
---
 >     # LOCALPATCH
> # i586 is 32-bit, amd64 is 64-bit, unless ARCH_DATA_MODEL is explicitly set
 >     # as 32 and ARCH will be demoted to i586
232a235,239
 >     else
 >       ifeq ($(ARCH_DATA_MODEL), 32)
 >       ARCH=i586
 >       ARCH_FAMILY := $(ARCH)
 >       endif



Reply via email to