Thumbs down -- sorry Tim, this fix breaks the product build.
-Xiomara
On 03/31/09 13:26, Tim Bell wrote:
I wrote:
One question - if the user goes to the trouble to set any of
ALT_BINARY_PLUGS_JARFILE, ALT_BINARY_PLUGS_PATH,
ALT_BUILD_BINARY_PLUGS_PATH, ALT_CLOSED_JDK_IMPORT_PATH
(See the comments in jdk/make/common/Defs.gmk starting at line 127),
should we assume they must really, really want the binary plugs and
force IMPORT_BINARY_PLUGS=true? Or have them set it as well?
I am thinking we shouldn't do this automatically. I notice in the
logs that JPRT is setting these even when IMPORT_BINARY_PLUGS=false.
Review feedback convinced me to reverse that last statement.
Here is round two - please take a look:
http://cr.openjdk.java.net/~tbell/6819847/webrev.01/
With these changes the default behavior is as if
IMPORT_BINARY_PLUGS=false
Unless the user explicitly sets any of the PLUGS variables:
ALT_BINARY_PLUGS_JARFILE, ALT_BINARY_PLUGS_PATH,
ALT_BUILD_BINARY_PLUGS_PATH, ALT_CLOSED_JDK_IMPORT_PATH
Setting these will force IMPORT_BINARY_PLUGS=true
The other case is if a user outside the Sun network sets
IMPORT_BINARY_PLUGS=true. Here they will need to set one of the
ALT_..._BINARY_PLUGS variables to point to the plugs anyway.
Thanks in advance for feedback-
Tim Bell
