My fault. I reviewed this and it didn't dawn on me what this did
until your email.

Yes, the default production builds with javac should be source,lines.
Sorry, I had native code on the brain and was thinking 'debug off' :^(

-kto

Jonathan Gibbons wrote:
Andrew,

It's one thing to be enabling more debug information if you set flags, and/or making it more consistent, but I'm not happy with you removing debug information by default. At least from reading the changeset diff, it seems there is no way to get what was previously the default amount of debug info, which is source,lines (but not vars).

Source and lines are good to get useful stack traces in the face of exceptions, even if var information is not present. var information is typically not required in product builds.

-- Jon



Begin forwarded message:

*From: *...@redhat.com <mailto:a...@redhat.com>
*Date: *April 17, 2009 8:15:39 AM PDT
*To: *jdk7-chan...@openjdk.java.net <mailto:jdk7-chan...@openjdk.java.net>, build-dev@openjdk.java.net <mailto:build-dev@openjdk.java.net> *Subject: **hg: jdk7/build/langtools: 6829575: 100028: Debug information is incomplete or missing*

Changeset: 4b72c2556789
Author:    aph
Date:      2009-04-17 15:56 +0100
URL: http://hg.openjdk.java.net/jdk7/build/langtools/rev/4b72c2556789

6829575: 100028: Debug information is incomplete or missing
Summary: Enable debugging in many places
Reviewed-by: ohair
Contributed-by: Andrew Haley <a...@redhat.com <mailto:a...@redhat.com>>

! make/Makefile


Reply via email to