Dito on Jonathan's comments.
Once it's ready I'll do some test builds on all platforms.
FYI... The bugid for the changeset should be:
6837665: Deal with windows ant problem where commas in -D options do not work
(Hopefully we can use bugzilla bugid soon)
-kto
Jonathan Gibbons wrote:
Andrew,
The new comment in build.xml is somewhat misleading. It refers
to setting the property before the include of build.properties,
but you place the logic and the comment before including a different
file, and after including two more.
I would suggest moving the new lines up to the beginning of the
project, at line 34.
(And, there's a type in the comment -- "fore" instead of "for".)
-- Jon
P.S. Uugh to Ant syntax.
On May 6, 2009, at 6:11 AM, Andrew Haley wrote:
Kelly O'Hair wrote:
Recent javac.debuglevel changes to the OpenJDK7 jdk7/build forest
have run smack into the ant windows issue regarding commas in
command lines:
https://issues.apache.org/bugzilla/show_bug.cgi?id=46561
Not all windows users run into this, it depends on whether the
bin/ant.bat startup script is used (sh version is fine).
I've prepared a webrev for the jaxp and jaxws repositories to
just remove the use of javac.debuglevel:
http://cr.openjdk.java.net/~ohair/6837665-ant-debuglevel/webrev/
Andrew will likely have a webrev or diff for the langtools
repository soon.
At http://cr.openjdk.java.net/~aph/6837665-ant-debuglevel/
Andrew.
