I can't see the webrev right now due to the server issues.
As soon as I can look at it I'll let you know.
At first I wondered if it should be named ALT_JDK7_DROP_DIR,
but then I thought not, and I should have used jdk-drops
instead of jdk7-drops, getting the version out of the directory.
The file names should make them unique enough.
So your change may be fine as is, as soon as I can see it. ;^)
And I apologize for not creating an ALT_* setting before... my oversight.
-kto
Andrew John Hughes wrote:
2009/10/7 Andrew John Hughes <gnu_and...@member.fsf.org>:
2009/9/22 Kelly O'Hair <kelly.oh...@sun.com>:
This 6856630 change has been integrated into the build
forest jaxp and jaxws repositories:
http://hg.openjdk.java.net/jdk7/build/jaxws/rev/ae2bec597586
http://hg.openjdk.java.net/jdk7/build/jaxp/rev/534e23823a1b
Assuming we get successful test builds of the build forest, these
changes will get integrated into the jdk7 master forest.
Notes:
* The jaxws (and jaf) and jaxp sources have been extracted and
put into separate source zip files. These zip files represent
the source deliveries into the jdk7 project. Selection of
the bundles is determined by the properties in the files
jax*/jax*.properties and jax*/build-defs.xml.
The current 3 source drop bundles are:
jdk7-jaf-2009_08_28.zip
jdk7-jaxp-2009_08_28.zip
jdk7-jaxws-2009_08_28.zip
If not found in the /java/devtools/share/jdk7-drops directory,
the ant scripts will look for them at
http://kenai.com/projects/jdk7-drops/downloads
a temporary site for now until the JAX* teams engage.
* The original jaxp/src and jaxws/src files are still there,
but should not be used unless the drop source bundles are
unavailable (currently the drop bundles contain the exact
same files). A warning will be issued if they are used.
Eventually the original jaxp/src and jaxws/src files will
be deleted from the jdk7 repositories.
* 'ant source' or 'cd make && make source' will get the drop
bundles and populate the drop source area. But this should
happen automatically.
Please ask questions, this is kind of a big change and anything
can go wrong, please let me know if there are problems.
-kto
Hi Kelly,
This patch is now in b73 and I'm trying to get IcedTea7 to build with
it. How do I specify the location of the zips to use?
Thanks,
--
Andrew :-)
Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)
Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8
I found a number of issues with the current version:
* The drop zips are expected to be in a share/jdk7-drops subdirectory
of the devtools directory. This doesn't really work outside Sun's
internal setup. I've added support for ALT_DROP_DIR which can be used
to specify an exact path to the zips. If this is not set, the old
devtools behaviour is used.
* The zips are being downloaded and extracted in the source directory,
which could be read only. I've changed this so they are written to
the build directory like everything else.
The webrev for these changes is here:
http://cr.openjdk.java.net/~andrew/drops/webrev.01/
I've committed this to IcedTea already. Does this look ok for build also?
