Alan Bateman wrote:
Mandy Chung wrote:
We have made some progress in eliminating several undesirable
dependencies in the past few builds [1]. A class analyzer tool in
the jigsaw/tools repository [2] has been developed and used to
analyze the dependencies.
The next step of the jdk modularization effort is to make the build
changes to generate modules. I plan to break this task into several
steps. The first step is to add a new "modules" target to build the
module image that has one jar file per module rather than rt.jar.
This change does not have any impact to the existing jdk build.
Webrev at:
http://cr.openjdk.java.net/~mchung/6909572/webrev.00
Mandy - I finally got to through this (actually the updated version
http://cr.openjdk.java.net/~mchung/6909572/webrev.01/).
This is a useful first step, so good job and consider it reviewed. My
only comment is that it duplicates some of the beast that is
Release.gmk. I don't have suggestions but someday we should re-visit
these (and I've no doubt we'll be changing this many times in jdk7
anyway).
Thanks for the review. W.r.t. the Modules.gmk, I think it could become
much simpler after I fix:
6911737: Module build: generate modules with native libraries and
any other files
That's one of the tasks that I would look into next.
A couple of minor nits:
- make/Makefile - do you want to list the modules target, maybe as
experimental, under development, ...
I will add that.
- make/common/Modules.gmk needs the date in the copyright message to
be fixed
- make/modules/jdk7.depconfig - we should add a copyright header to this
Will fix them.
Mandy
-Alan.
