The fixes look fine.

I find an interesting thing here: Since I only build the jdk repository, all 
jars created has MANIFEST.MF with

    Created-By: 1.6.0_20-ea (Sun Microsystems Inc.)

I wish in your control build it shows Oracle.

BTW, when is this going to an end? There are still more than a thousand of 
"Sun" words inside the workspace and they might need multiple bugs to cover. 
Anyway, I suggest the following be handled first because they show in final 
builds:

. "@author Sun Microsystems" in sample directory
. In THIRD_PARTY_README, jre/THIRD_PARTY_README, LICENSE, jre/LICENSE
. man pages
. lib/ir.idl, lib/orb.idl

Thanks
Max

On May 28, 2010, at 12:48 PM, Kelly O'Hair wrote:

> 
> Need reviewer: fixing some rebranding issues during the build
> 
> 6949590: exes(java.exe, javaws.exe) show Copyright Year as 2004, COMPANY as 
> Sun
> 6955707: Correct addNotices.sh logic in Makefiles
> 
> http://cr.openjdk.java.net/~ohair/openjdk7/rebranding-gensrc/webrev/
> 
> -kto

Reply via email to