On Thu, Jul 1, 2010 at 00:23, Ulf Zibis <[email protected]> wrote: > Oops, it's never superfluous to review again: > > Line 245: too much spaces > Compare line 363 vs 376 etc.: inconsistent indentation after @since > Line 598: can be deleted > Line 600: 2 spaces after @exception > Line 600: 2 spaces after NullPointerException > Line 600: better use @throws > Line 652: shoudn't you add a @suppressWarnings before // But I still think, > a little comment would be better. > Line 4706: 2 spaces after ch should be enough (you can donate it to line > 4736 after codePoint ;-) ) > Line 5297, 5330: one more space after @return > Line 5812: another type of indentation iregularity > ... (there are some more irregularities in this class on indentation and > spacing) > ... I think, the time has come to replace things like: > <code>'\u005A'</code>
Too late; I've committed my changes; we can always create a new batch of webrevs. As you know, I think @exception is worth changing to @throws, but only via automated script. Martin > -Ulf > > > > Am 30.06.2010 19:50, schrieb Martin Buchholz: >> >> On Wed, Jun 30, 2010 at 01:22, Ulf Zibis<[email protected]> wrote: >> >>> >>> Am 29.06.2010 02:29, schrieb Martin Buchholz: >>> >> >> >>>> >>>> I tried to do that, but Character.java is one of those classes >>>> that needs to be compilable by the bootstrap JDK, >>>> so this change ist leider nicht moeglich. >>>> >>>> >>>> >>> >>> I think, there should be a note about this in the sources of those >>> classes. >>> >> >> Such a note is likely to become obsolete soon. >> >> >>> >>> Maybe it's possible to have 2 versions, one for the bootstrap + another >>> for >>> the final compilation. >>> >> >> It's not a crime to implement language FOO(N) in language FOO(N-1). >> >> Martin >> >> >> > >
