-------- Original Message --------
Subject: Re: Need reviewer: Boot jdk needs to be 1.6, minor fixes to javadoc generation
Date:   Mon, 2 Aug 2010 19:15:50 -0400
From:   John Yeary <johnye...@gmail.com>
To:     Jonathan Gibbons <jonathan.gibb...@oracle.com>



Looks good to me.

On Mon, Aug 2, 2010 at 6:44 PM, Jonathan Gibbons <jonathan.gibb...@oracle.com <mailto:jonathan.gibb...@oracle.com>> wrote:

   Looks good to me.

   -- Jon


   On 08/02/2010 03:40 PM, Kelly O'Hair wrote:

       Need reviewer: Boot jdk needs to be 1.6, minor fixes to javadoc
       generation

       6973616: Update minimum boot jdk from 1.5 to 1.6
       6971426: jdk/make/docs docs target does not work on windows

       http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-6971426%2b6973616/webrev/
       
<http://cr.openjdk.java.net/%7Eohair/openjdk7/jdk7-6971426%2b6973616/webrev/>

       The boot jdk really needs to be at least 1.6 for jdk7.

       The jdk/make/docs/Makefile was recently re-worked but it wasn't
       very forgiving during partial
       builds where some of the directories might not exist, or when
       unrelated platform specific directories
       were purposely not included during the build.
       Note that even though the javadocs can be built on windows
       machines now, developers might want
       refrain from actually doing it on windows due to the build time
       hit and the fact that it is still not a
       complete documentation set when generated on windows (jvmti.html
       is not generated on windows).

       -kto





--
John Yeary
--
http://javaevangelist.blogspot.com

"Far better it is to dare mighty things, to win glorious triumphs, even though checkered by failure, than to take rank with those poor spirits who neither enjoy much nor suffer much, because they live in the gray twilight that knows not victory nor defeat."
-- Theodore Roosevelt

Reply via email to