The change looks fine, but I suspect that between the time you push
this change, and a promoted jdk7 build is created from it,
anyone building the jdk repository by itself will fail because the
imported jdk7 image won't have these files.
A bit of a catch22.
Either the change needs to include some kind of check for existence:
ifneq ($(wildcard $(LIB_LOCATION)/$(SERVER_LOCATION)/$
(JVMDTRACE_NAME)),)
...
endif
which could be removed after the promotion.
Or you need to time this change so it happens very shortly before the
promotion.
-kto
On Sep 9, 2010, at 6:24 AM, Keith McGuigan wrote:
Hello,
I'd like a code review for this change which imports the
libjvm_db.so and libjvm_dtrace.so files from Hotspot into the
solaris JDK images (libjvm_dtrace was missing, and libjvm_db was
missing for x86).
http://cr.openjdk.java.net/~kamg/6983225/webrev.00/
Thanks!
--
- Keith
