On Mar 21, 2011, at 8:47 PM, David Holmes wrote: > Hi Kelly, > > Can't comment on technical accuracy but it seems to read fine and html seems > ok. A couple of minor textual nits: > > - Cross-references to the "building GNU make" section should say "Building" > with a capital B (and even have the cross-ref in double-quotes)
Done. > > - For <b>X64</b>, builds, -> For <b>X64</b> builds, (extraneous comma) Done. > > - For the 3 tips on Windows VS2010 use a nested list Done. > > - C:/temp is just an example -> C:\temp is just ... ? Good catch, Done. > > > Now a couple of technical content queries: > > - noticed minimum build env lists gcc 4, but that has to be gcc 4.3 now for a > JDK build. Good catch. Now 4.3. > > - Under "Build Information" it states "Building the OpenJDK is done with a > gmake command" but I think it should say "a GNU make command". The example > can then clarify that it is a Solaris example and so uses gmake as the name > of thje command Done. Thanks! -kto > > Cheers, > David > > Kelly O'Hair said the following on 03/22/11 12:51: >> Need reviewer: openjdk7 Build README >> 6896934: README: Document how the drop source bundles work for jaxp/jaxws >> 6896978: README: Updates to openjdk README-builds.html >> 6903517: README: OpenJDK additions needed - cygwin issues >> http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-READMEs/webrev/ >> -kto
