While the code is fine and I won't complain if you push it as is, I
don't like the idea that we "disable" the altsrc mechanism when
building OPENJDK. The idea of alternate sources is that distributions
ought to be able to define their own distribution-specific code.
OPENJDK could well have (in the future) openjdk-specific code and use
the altsrc mechanism to build it.
What if, instead of making the 'disabled' comment and setting
HS_ALT_SRC_REL to NO_SUCH_PATH, we set it to something like "src/
openjdk"? Since that path doesn't exist yet, the end result should be
the same, but if someday someone wants to add openjdk-specific code
the makefiles would be all set to handle that.
If we really just want to disable altsrc altogether, I think we should
use a different input/env variable to indicate that (not OPENJDK).
Something like COMMON_CODE_ONLY, or DISTRO_INDEPENDENT.
--
- Keith
On May 5, 2011, at 12:26 AM, David Holmes wrote:
Okay now that my brain is functioning again lets see if it is third-
time lucky:
http://cr.openjdk.java.net/~dholmes/7036525/webrev.2/
This reverts things back to my original webrev where we set
HS_ALT_SRC_REL to NO_SUCH_PATH. It has to be a non-existent path
otherwise it will appear in the generated definitions for Src_Dirs_I
and Src_Dirs_V.
The user can override this by setting OPENJDK=true and
HS_ALT_SRC_REL=<whatever> as variables on the make invocation eg:
gmake OPENJDK=true HS_ALT_SRC_REL=/my/dist/src product1
Thanks,
David
