On May 12, 2011, at 4:33 PM, Omair Majid wrote: > Hi Kelly, > > On 05/12/2011 04:39 PM, Kelly O'Hair wrote: >> >> Need reviewers. (Omair, you will want to verify this works for IcedTea). >> >> Some background: this changeset: >> http://hg.openjdk.java.net/jdk7/jdk7/rev/47f6b7db1882 >> Created some issues for people setting ALT_OUTPUTDIR to a vanilla path like >> /tmp/foobar. >> The expectation was that a debug build would show up in /tmp/foobar-debug, >> but it was showing >> up in /tmp/OS-ARCH-debug. >> The original changeset was mostly dealing with a Windows issue where you >> cannot just append >> characters to an existing path and expect that path to be valid, so a >> technique of doing a /../ was used. >> >> This fix tries to make it a bit more obvious what is going on, although I >> have to admit it's a confusing >> situation regardless. >> >> 7043700: Regression for IcedTea builds >> http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-outdebug-7043700/webrev/ >> > > Thanks for creating a patch. Sorry, but it took me a little while to tests > this out - the patch is a little hard to read (and I cant follow the logic of > most of the changes). Unfortunately it seems to have a bug (or am I building > it wrong?). > > I used the following command to build: > $ ALLOW_DOWNLOADS=true LANG=C ALT_BOOTDIR=/usr/lib/jvm/java-openjdk/ > ALT_OUTPUTDIR=/home/omajid/temp/openjdk7/builds/new-build make debug_build > > But the build directory doesn't look quite right: > > $ pwd > /home/omajid/temp/openjdk7/builds > $ ls > new-build new-build-debug > $ ls new-build > bundles source-bundles tmp > $ ls new-build-debug/ > j2sdk-image > $ ls new-build-debug/j2sdk-image/ > bin btjars corba gennativesrc impsrc j2sdk-image > langtools sanityCheckMessages.txt symbols > btbins bundles demo gensrc include jaxp lib > source-bundles tmp > btclasses classes democlasses hotspot j2re-image jaxws sample > source_tips > > The j2sdk-image directory contains another j2sdk-iamge directory :( > > I suspect this is the cause (from the patch): > > - > ALT_OUTPUTDIR=$(ABS_OUTPUTDIR)/../$(PLATFORM)-$(ARCH)-$(DEBUG_NAME) \ > + ALT_OUTPUTDIR=$(ABS_OUTPUTDIR)/$(REL_JDK_IMAGE_DIR) \ > > REL_JDK_IMAGE_DIR ends with j2sdk-image. I suppose you might want to create > another variable which is REL_JDK_IMAGE_DIR without the j2sdk-image part and > use that with ALT_OUTPUTDIR.
You are right, I messed up. I have updated the webrev. -kto > > Thanks, > Omair
