Looks good. -kto
On Oct 19, 2011, at 11:30 PM, Sean Chou wrote: > Hi all, > > Would anyone like to review this patch ? The problem it trying to fix is > very simple, just > add the version information to the dll files in demo. > > The bug link is: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6988099 > The webrev is: http://cr.openjdk.java.net/~ngmr/6988099/webrev.00 > > On Fri, Sep 30, 2011 at 9:28 PM, Zhengyu Gu <zhengyu...@oracle.com> wrote: > Hi All, > > Could you please help with code review? After that, I can help to push to > jdk8. > > Thanks, > > -Zhengyu > > On 9/19/2011 2:43 AM, Sean Chou wrote: >> >> Thanks to Gu and Neil. >> >> 2011/9/16 Zhengyu Gu <zhengyu...@oracle.com> >> Okay, once review is completed, I would help you to push to jdk8. >> >> Thanks, >> >> -Zhengyu >> >> >> On 9/15/2011 2:51 PM, Neil Richards wrote: >> On Thu, 2011-09-15 at 12:14 -0400, Zhengyu Gu wrote: >> No progress been made. Any reason should be resolved right away? >> >> Thanks, >> >> -Zhengyu >> >> On 9/15/2011 2:50 AM, Sean Chou wrote: >> Hi, >> About this bug, is there any progressing ? >> >> >> 2011/6/8 Zhengyu Gu<zhengyu...@oracle.com> >> No, I did not make any progress on 6988099, as it was >> deferred to JDK8. With Dan's comment, looks good to me. >> >> Thanks, >> >> -Zhengyu >> I've made a couple of modifications to Sean's suggested change, in >> response to Dan's comments: >> >> * For Windows, added '$(DEMO_VERSION_INFO)' to 'LDLIBS.demo', so >> that the line of the link command doesn't need to be modified, >> and so 'DEMO_VERSION_INFO' isn't used outside a windows-specific >> context. >> * Wrapped the definition of 'RC_FLAGS' in a windows-specific >> block. >> >> I've uploaded the resulting webrev for your review and blessing [1]. >> >> If you're happy with change, I'll look to commit it up into >> jdk8/build/jdk >> >> Regards, Neil >> >> [1] http://cr.openjdk.java.net/~ngmr/6988099/webrev.00 >> >> >> >> >> -- >> Best Regards, >> Sean Chou >> > > > > -- > Best Regards, > Sean Chou >
