On 23/10/2011 23:43, David Holmes wrote:
Hi Chris,

On 22/10/2011 1:43 AM, Chris Hegarty wrote:
All of the security native libraries have runtime dependencies on
libjava and libjvm, most of which are completely unnecessary. This CR
proposes to remove these dependencies and provide localized versions of
the trivial utility functions that are being used from libjava, i.e. the
JNU_ThrowXXX functions.

There is also a dependency on JNI_GetCreatedJavaVMs which can easily be
removed by caching a reference to the JavaVM when the library is loaded,
in JNI_OnLoad, and making this reference available within the library
itself.

http://cr.openjdk.java.net/~chegar/7103549/webrev.oo/webrev/

In make/sun/security/krb5/Makefile you dropped -ldl - was that intentional?

Yes, this was just a little cleanup. I noticed that there was no dependency on libdl.so from this library. I suspect this may have original just been copied form another makefile.

In fact, the dlopen, dlsym, etc, functions (that are the usually the cause for linking against ldl) are part of the standard C library functions on Solaris, so ldl could be Linux specific. But I didn't want to get too much involved in cleanup here.

-Chris.


Otherwise looks ok to me.

David

-Chris.

Reply via email to