Seems that instead of overriding we should be setting
MAX_VM_MEMORY = max (MAX_VM_MEMORY, 1024)
Ivan
On 2011-10-27 20:41, Volker Simonis wrote:
I've just realized that building the JDK documentation for a 32-bit
build of JDK8 on Windows (with JDK7 as bootstrap JDK) fails:
C:/OpenJDK/jdk1.7.0_01/bin/java -XX:-PrintVMOptions
-XX:+UnlockDiagnosticVMOptions -XX:-LogVMOutput -client -Xmx512m
-Xms512m -XX:PermSize=32m -XX:MaxPermSize=160m
"-Xbootclasspath/p:C:/OpenJDK/output_x86/langtools/dist/bootstrap/lib/javadoc.jar;C:/OpenJDK/output_x86/langtools/dist/bootstrap/lib/javac.jar;C:/OpenJDK/output_x86/langtools/dist/bootstrap/lib/doclets.jar"
-jar C:/OpenJDK/output_x86/langtools/dist/bootstrap/lib/javadoc.jar
-bootclasspath c:/OpenJDK/output_x86/classes -d
c:/OpenJDK/output_x86/docs/api \
@c:/OpenJDK/output_x86/tmp/docs/doctmp/coredocs.options
@c:/OpenJDK/output_x86/tmp/docs/doctmp/coredocs.packages
..\..\src\share\classes\java\lang\invoke\MethodHandle.java:392:
warning - Tag @link: reference not found: Objects.equals
java.util.Objects#equals
c:\OpenJDK\output_x86\impsrc\javax\xml\bind\JAXBContext.java:262:
warning - Tag @see: reference not found: S 7.4.1 "Named Packages" in
Java Language Specification</a>
javadoc: error - java.lang.OutOfMemoryError: Please increase memory.
For example, on the JDK Classic or HotSpot VMs, add the option -J-Xmx
such as -J-Xmx32m.
1 error
2 warnings
> From the error it seems as if this can also happen on other platforms.
The problem is caused by the following setting in jdk/make/docs/Makefile:
67 # We override whatever the max VM memory setting is here.
68 # NOTE: javadoc will not complete without these larger settings.
69 # WARNING: This could cause thrashing on low memory machines.
70 ifeq ($(ARCH_DATA_MODEL),64)
71 MAX_VM_MEMORY = 1024
72 else
73 MAX_VM_MEMORY = 512
74 endif
The 64-bit build succeeded without a problem, so apparently 1024m
seems to be big enough.
I think the problem is that I'm trying to build a 32-bit VM on a
64-bit Windows OS, so I set ARCH_DATA_MODEL to '32'.
I know that the README mentions that 32-bit compiles are not supported
on 64-bit OSes, but besides this problem, everything else works fine,
so I think this should be fixed.
Regards,
Volker
