On 12/16/11 09:57 AM, Alan Bateman wrote:
On 16/12/2011 02:59, Stuart Marks wrote:
...
Stuart - the changes look okay to me but it would be good to get
confirmation that you've done both full and partial builds with these
changes. Also I think we need confirmation that incremental builds in
each of these areas isn't impacted. My concern is implicit compilation
where compiling code in warning free areas may compile code in areas
that are not warning free yet. Sasha did great work over the summer and
part of his approach was to make warnings fatal in the errors that he
cleaned up. On a couple of occasions we ran into issues where implicit
compilation caused code in areas with warnings to be compiled. Such
issues are usually quick to fix but I'm sure you get my concern.
I agree with Alan here, we need to be careful that incremental/partial
builds are still ok. We found some issues relating to this in the
networking area recently.
Have there been changes recently to the -Xlint options or something?
I was horrified to find yesterday that my build completed "successfully"
even though there was an error in HttpURLConnection.java. This
networking class was being implicitly compiled by other makefiles, that
seems to have Xlint enabled, but not fatal.
I need to look into why this didn't cause the build to fail.
-Chris.
-Ala
