On 2012-02-16 07:21, David Holmes wrote:
On 16/02/2012 1:06 AM, Erik Joelsson wrote:
New webrev:
http://cr.openjdk.java.net/~erikj/7141244/webrev.04/
175 lines changed: 87 ins; 29 del; 59 mod; 3970 unchg

I discovered that the -include $(SPEC) line needed to be added to the
make/{bsd,solaris,linux}/makefiles/buildtree.make files. Otherwise the
hotspot build won't respect setting OPENJDK=true in the spec.

Is that the only change from version 3?

That is the only change yes.
Have you verified you can do all three variants: openjdk, jdk, embedded jdk?

Not sure how you mean. The problem I corrected was discovered during development in the build-infra repo, where I'm currently working on the open vs non open scenarios. We haven't started looking at embedded much yet (build-infra isn't currently building on anything but linux atm). This issue, and the change, has no impact on the old build system, either building just hotspot or from the root repo. I'm running my hotspot-rt through jprt now anyway to be sure.

/Erik


Reply via email to