Frederik, > In the new build system, the StripProperties and CompileProperties > will be annotation processors inside the smart javac wrapper inside > langtools. Neat and clean.
OK. Thank you! It probably much better than sed script with conditional changes. -Dmitry On 2012-03-13 13:47, Fredrik Öhrström wrote: > 2012-03-13 10:24, Dmitry Samersoff skrev: >> Frederik, >> >> Just a curious - why we need a Java program here? >> Could sed do the same with less efforts? > > In the old build system, there are two StripProperties.java > in corba and in the jdk with slightly different implementations > and command line options. And there are two CompileProperties.java > in langtools and in the jdk. Also slightly different. > > There is >also< a broken sed implementation of StripProperties > in the jdk, and sometimes the properties files are simply copied over. > > The net result is that, for property files. > > Sometimes compiled to a bytecode class, and for those that remain text: > : is sometimes translated to \: > = is sometimes translate to \= > # comment is sometimes cleaned to only #, in a broken way, since # > inside text strings mutilates the text string. > # comment is sometimes removed completely. > \u00E9 is sometimes translated to binary E9, ie part of iso8859-1 > translation, but not always. > The key values are sometimes sorted into a stable random sort. > > If this does not make you go, bleeech, I do not know what will. > > In the new build system, the StripProperties and CompileProperties > will be annotation processors inside the smart javac wrapper inside > langtools. > Neat and clean. > > Oh, and the contortions the common/bin/compareimages.sh script have to > go through to > manage to compare the properties files between the old a new build in > some sensible way. > :-) > > //Fredrik -- Dmitry Samersoff Java Hotspot development team, SPB04 * There will come soft rains ...
