Thanks for the reviews!
On 2012-03-19 02:21, David Holmes wrote:
Minor nit, when you say:
# On 32 bit <OS-NAME> we build server and client, on 64 bit just server.
the OS isn't actually relevant. If we ask for a 32-bit build then we
build both client and server; if we ask for a 64-bit build then we
build server only (by default).
So AFAICS the only platform dependent part here is adding kernel on
Windows - right? If so then once we do the kernel->minimal transition
this can be refactored into the defaults section of the top-level
defs.make
Yes, the only platform dependent part is kernel on Windows. Will minimal
be built on all OSes and not just Windows then? If that's the case, then
yes, there is no need for duplicating this logic in the platform
specific files.
I've created an exported change and put it here:
http://cr.openjdk.java.net/~erikj/7141246/hotspot-change
/Erik
