Thanks Serguei!
Dan
On 4/2/12 1:38 PM, serguei.spit...@oracle.com wrote:
Dan,
I've reviewed all 3 webrevs.
They look fine.
Thanks,
Serguei
On 3/30/12 10:32 AM, Daniel D. Daugherty wrote:
Greetings,
In my recent Full Debug Symbols changes, I added the new
ENABLE_FULL_DEBUG_SYMBOLS build flag. I originally implemented
this flag to disable debug info for all build configs which
doesn't make a whole lot of sense for non-product builds. After all
what's a debug build without debug info? (Pretty much the same
thing as a product build).
As is usual, I have one bug to track the hotspot repo changes and
another bug to track the other repos:
7157296 3/4 FDS: ENABLE_FULL_DEBUG_SYMBOLS flag should only affect
OPT builds
7158067 4/4 FDS: ENABLE_FULL_DEBUG_SYMBOLS flag should only affect
product builds
Here are the webrev URLs:
http://cr.openjdk.java.net/~dcubed/fds_revamp/7157296-webrev/0-jdk8-root/
http://cr.openjdk.java.net/~dcubed/fds_revamp/7158067-webrev/0-jdk8-hotspot/
http://cr.openjdk.java.net/~dcubed/fds_revamp/7157296-webrev/0-jdk8-jdk/
Thanks, in advance, for any review comments.
Dan
