25 apr 2012 kl. 17:23 skrev Dmitry Samersoff <dmitry.samers...@oracle.com>:
> Magnus, > > Fix looks good for me. > > The only question - why we should patch both configure.ac > and configure ? > > I believe we generate configure from configure.ac Yes we do, but we keep a generated configure checked in in the repo, so users are not required to have the autoconf tool locally installed to be able to build. Hence, every time configure.ac is modified, configure will be updated as well. /Magnus > > -Dmitry > > > On 2012-04-25 17:32, Magnus Ihse Bursie wrote: >> On 2012-04-23 18:01, Dmitry Samersoff wrote: >>> Magnus, >>> >>> I'm second to Kelly. >>> We shouldn't have executable scripts in repository. >> >> Ok, so here comes a new, even simpler patch. :-) >> >> http://cr.openjdk.java.net/~ihse/logger.sh-missing-x-permission/webrev.01/ >> >> /Magnus >> > > > -- > Dmitry Samersoff > Java Hotspot development team, SPB04 > * There will come soft rains ...
