Done: http://hg.openjdk.java.net/jdk8/build/jdk/rev/c2d9166f3284
To clarify, this is a surgical fix to one sed command to deal with Hudson adding @ characters to pathnames. I'm still of the opinion that adding @ characters to paths is a bad idea, but this change is harmless and helps the RE team with their use of Hudson. Let's hope they don't start adding | characters to path names, or worse, spaces. ;^) -kto On May 11, 2012, at 7:47 AM, Magnus Ihse Bursie wrote: > The Release Engineering team in Oracle encountered a problem when building in > a path that contained the character "@". Normally, having strange names in > the directory where you are building is not a good idea, but in this case the > path was created by the Hudson CI system. > > The problem is a single sed expression, basically "sed -s@...@..@". I changed > this to "sed -s|...|...|", a character that is much less likely to actually > appear in a filename. > > Webrev here: > > http://cr.openjdk.java.net/~ihse/fix-compare-image-sed/webrev.00/ > > Kelly, if this is accepted by reviewers, can you create a bug and push this? > > /Magnus >
