Are these ok? ./share/classes/sun/nio/ch/DatagramChannelImpl.java:@GenerateNativeHeader ./share/classes/sun/nio/ch/IOStatus.java:@GenerateNativeHeader ./share/classes/sun/nio/ch/sctp/SctpStdSocketOption.java:@GenerateNativeHeader ./solaris/classes/sun/nio/ch/sctp/AssociationChange.java:@GenerateNativeHeader ./solaris/classes/sun/nio/ch/sctp/PeerAddrChange.java:@GenerateNativeHeader ./solaris/classes/sun/nio/ch/sctp/ResultContainer.java:@GenerateNativeHeader ./windows/classes/sun/nio/ch/PollArrayWrapper.java:@GenerateNativeHeader
Otherwise, the change looks ok to me, although I was puzzled by the "| $(BUILD_JDK)" in 314 $(JDK_OUTPUTDIR)/classes/_the.jdk.base.headers: $(JDK_BASE_HEADER_JAVA_FILES) | $(BUILD_JDK) Never seen a | character in the dependencies before, is that a valid syntax? -kto On Jun 4, 2012, at 7:15 AM, Erik Joelsson wrote: > I have created a (hopefully temporary) hack to run javah manually for these 5 > classes. This webrev is just against the build-infra repo. Unless anybody > objects to this temporary solution, I will publish a new full webrev against > the jdk8/build forest tomorrow. > > http://cr.openjdk.java.net/~erikj/build-infra-m1.1/jdk-base-headers/ > <http://cr.openjdk.java.net/%7Eerikj/build-infra-m1.1/jdk-base-headers/> > > /Erik > > On 2012-05-23 19:05, Alan Bateman wrote: >> On 23/05/2012 17:50, Kelly O'Hair wrote: >>> Has anyone tried creating an unused native method declaration in the class >>> to trigger the native header >>> generation? public native void GenerateNativeHeader(); ??? Is that too >>> ugly? >>> >>> -kto >> As Jon put it, for the classes in the base module, "we are delicate >> bootstrapping ground" so if you add something like "private static native >> void dummy()" rather than the annotation to the classes in the base module >> then it could be a solution for the short term. This means the following >> sources in the webrev: >> >> src/share/classes/java/lang/Integer.java >> src/share/classes/java/lang/Long.java >> src/share/classes/java/net/SocketOptions.java >> src/windows/classes/sun/nio/ch/PollArrayWrapper.java >> >> Also it would be good to remove it from >> src/share/classes/sun/nio/ch/IOStatus.java too (it got the annotation in the >> first round). >> >> -Alan. >>
