I just pushed this change in. -kto
On Jun 11, 2012, at 5:57 AM, Erik Joelsson wrote: > And I've found two issues in the windows build that I would like to correct. > > http://cr.openjdk.java.net/~erikj/build-infra-m1.1/webrev-jdk-windowsfix/ > > makefiles/java/redist/sajdi/Makefile > The windows build broke when the full debug symbols were introduced. In > 7170079, we haven't converted full debug symbols yet. The webrev contains a > small fix (copying make/java/redist/sajdi/Makefile) which makes the build > pass, but still without properly working full debug symbols. A full > conversion of that feature will be in the next major push. > > makefiles/CompileJavaClasses.gmk > My temp fix for generating headers for specific classes in jdk.base failed on > windows. The reason for using the variable PLATFORM is that it's commonly > used in that file at this point. > > With these two, the windows build works at least as well as it used to before > 7170079. > > /Erik > > On 2012-06-08 19:32, Kelly O'Hair wrote: >> >> Technically, I had plenty of reviewers via the build-infra team, my wording >> was a bit off on this email. Sorry. >> >> These new build-infra changes have now been pushed into the jdk8/build >> forest. >> >> I have NOT verified the build-infra builds, only verified that the existing >> old makefiles are not impacted. >> This probably won't be integrated into jdk8/jdk8 until the middle of next >> week. >> So we have time to adjust any issues in jdk8/build that we find prior to >> Tuesday evening (Pacific time) or so. >> >> >> Many thanks to the build-infra team and all the hard work on this. >> >> -kto >> >> On Jun 7, 2012, at 8:10 PM, Kelly O'Hair wrote: >> >>> No impact to the current makefiles. >>> >>> This is changes for the new build-infra makefiles. >>> >>> I'm sure there is more to come. >>> >>> Thanks to Erik, Magnus, Fredrik, and Jonas. If I missed anyone else that >>> has contributed on this, my apologies. >>> >>> 7170079: Adjustments to build-infra makefiles >>> http://cr.openjdk.java.net/~ohair/openjdk8/build-infra2/webrev/ >>> >>> -kto >>> >>>
