130 ( set -e ; \
131 cd 64 ; \
132 $(QUIETLY) $(ADD_GNU_DEBUGLINK) \
133 $(LIBJVM_DB_DEBUGINFO) $(LIBJVM_DB) ; \
134 )
Would be better as:
130 ( cd 64 && $(ADD_GNU_DEBUGLINK) $(LIBJVM_DB_DEBUGINFO)
$(LIBJVM_DB) )
And making GENERATED a full path scares me. That variable is used all over the
place.
Are we sure all uses are ok being full paths?
And shouldn't this 64 directory name be in a variable to make it more obvious?
Maybe LIBJVM_DIRNAME64=64?
Is this a last minute change that is expected to be extremely low risk? Doesn't
feel low risk. :^( Sorry.
-kto
On Jun 19, 2012, at 6:21 PM, Daniel D. Daugherty wrote:
> Greetings,
>
> This is an URGENT code review request for a Solaris specific Full Debug
> Symbols (FDS) fix. Due to a Makefile logic error, the full debug symbol
> files and related '_g' symlinks are created in the wrong sub-directory
> for a couple of the dtrace libraries. The incorrect paths have a double
> "64/" sub-directory, e.g.:
>
> solaris-<arch>/jre/lib/<arch>/client/64/64/libjvm_db.debuginfo
>
> These are the correct symlink paths:
>
> solaris-<arch>/fastdebug/jre/lib/<arch>/client/64/libjvm_g_db.debuginfo
> solaris-<arch>/fastdebug/jre/lib/<arch>/client/64/libjvm_g_dtrace.debuginfo
> solaris-<arch>/fastdebug/jre/lib/<arch>/server/64/libjvm_g_db.debuginfo
> solaris-<arch>/fastdebug/jre/lib/<arch>/server/64/libjvm_g_dtrace.debuginfo
>
> and these are the correct debug info file paths:
>
> solaris-<arch>/jre/lib/<arch>/client/64/libjvm_db.debuginfo
> solaris-<arch>/jre/lib/<arch>/client/64/libjvm_dtrace.debuginfo
> solaris-<arch>/jre/lib/<arch>/server/64/libjvm_db.debuginfo
> solaris-<arch>/jre/lib/<arch>/server/64/libjvm_dtrace.debuginfo
> solaris-<arch>/fastdebug/jre/lib/<arch>/client/64/libjvm_db.debuginfo
> solaris-<arch>/fastdebug/jre/lib/<arch>/client/64/libjvm_dtrace.debuginfo
> solaris-<arch>/fastdebug/jre/lib/<arch>/server/64/libjvm_db.debuginfo
> solaris-<arch>/fastdebug/jre/lib/<arch>/server/64/libjvm_dtrace.debuginfo
>
> where "<arch>" is "i586" or "sparc". The 64-bit Solaris platforms ("amd64"
> and "sparcv9") don't have this issue because they don't have the "64/"
> sub-directories.
>
> This fix is targeted at HSX-24/JDK8 and HSX-23.2/JDK7u6 and will resolve
> an issue that is preventing Oracle's Release Engineering scripts from
> running properly.
>
> Here is the webrev URL for the HSX-24/JDK8 version:
>
> http://cr.openjdk.java.net/~dcubed/fds_revamp/7175255-webrev/0/
>
> The HSX23.3/JDK7u6 version is the same except for the changes to
> make/solaris/makefiles/defs.make which are not needed in HSX23.2.
>
> Thanks, in advance, for any reviews!
>
> Dan
