I see a tiny issue with the script:

200     if [ -s ${tmpfile} ] ; then
201             diff -c ${tmpfile} ${template_dir}/${header} 1>&2
202             if [ "$?" = "0" ] ; then
203 echo "SUCCESS: The license header for "`pwd`"/"$1" has been verified."
204                     echo "###"
205             else
206                     echo "ERROR: License header is not correct in "`pwd`"/"$1 
1>&2
207                     echo "See diffs above. " 1>&2
208                     echo "###" 1>&2
209                     echo "" 1>&2
210                     error_status=1
211             fi

Here, there is a blank line after ERROR but none for SUCCESS.

Thanks
Max

/20/2012 09:36 AM, kelly.oh...@oracle.com wrote:
Changeset: 8fb4cd2f05a1
Author:    mbykov
Date:      2012-06-19 14:24 -0700
URL:       http://hg.openjdk.java.net/jdk8/build/rev/8fb4cd2f05a1

7178241: Basic script for JDK source code legal headers conformance verification
Summary: A new script lic_check.sh to check license headers in JDK source code
Reviewed-by: ohair, darcy
Contributed-by: misha.by...@oracle.com

+ make/scripts/lic_check.sh

Reply via email to