Why do you say they are unnecessary? -kto
On Jun 28, 2012, at 7:03 AM, Sergey Bylokhov wrote: > Hi, Kelly. > Looks like changes in these files are unnecessary. > Cdiffs Udiffs Sdiffs Frames Old New Patch Raw > src/macosx/classes/sun/lwawt/LWLabelPeer.java > > 4 lines changed: 4 ins; 0 del; 0 mod; 115 unchg > Cdiffs Udiffs Sdiffs Frames Old New Patch Raw > src/macosx/classes/sun/lwawt/LWTextFieldPeer.java > > 4 lines changed: 4 ins; 0 del; 0 mod; 134 unchg > > 23.05.2012 05:14, Kelly O'Hair wrote: >> 7170969: Add @GenerateNativeHeader to classes whose fields need to be >> exported for JNI >> http://cr.openjdk.java.net/~ohair/openjdk8/generateHeaders1/webrev/ >> >> The new build infrastructure wants to fully automate the generation of the >> JNI header files (running javah). >> On classes that have "native" methods this is obvious, but class that only >> export constants, and whose constants >> are needed in the JNI native code, we need to mark these classes as needing >> their native header file generated. >> >> This change is adding: >> >> import javax.tools.annotation.GenerateNativeHeader; >> >> /* No native methods here, but the constants are needed in the supporting >> JNI code */ >> @GenerateNativeHeader >> >> To any class without a native method, but needing to expose it's constants >> to the native code. >> >> -kto >> > > > -- > Best regards, Sergey.
