Looks ok to me.  I'll run this trough some build&test and integrate it into the 
jdk8/build repos.

There could be some impact to the existing builds, but the GenerateNativeHeader 
change should be harmless.

Using:

7181501: Add some GenerateNativeHeader annotations and misc Mac adjustments to 
makefiles

Anyone seeing any serious issues please scream.

-kto

On Jul 3, 2012, at 11:29 AM, Erik Joelsson wrote:

> When converting the mac build to build-infra, a bunch of files needed the new 
> annotation GenerateNativeHeader. In order to still compile in the old build, 
> langtools had to be added to the classpath in the ant script compiling those 
> classes, since they were compiled by the bootjdk javac rather than the 
> bootstrap javac.
> 
> In addition to this some of the java code used to generate java classes have 
> been modified to sort the output to make the generated classes deterministic. 
> This makes comparing the new and old build easier. Previously the order of 
> methods in these generated classes were random on hashvalues.
> 
> http://cr.openjdk.java.net/~erikj/build-infra-m1.2/webrev-jdk-mac/ 
> <http://cr.openjdk.java.net/%7Eerikj/build-infra-m1.2/webrev-jdk-mac/>

Reply via email to