Thanks Andrew! Dan
On 8/2/12 9:53 AM, Andrew Hughes wrote:
----- Original Message -----Greetings, I have a fix for the following Linux specific FDS bug: 7188168 4/4 7071904 broke the DEBUG_BINARIES option on Linux Here is the URL for the webrev: http://cr.openjdk.java.net/~dcubed/fds_revamp/7188168-webrev/0/ What the fix does is reorder and slightly tweak the Makefile logic that supports the DEBUG_BINARIES make option: - when 'DEBUG_BINARIES=true' is specified, the '-g' option is added to the CFLAGS make variable and none of the other {DEBUG,FASTDEBUG,OPT}_CFLAGS variables are touched - this fix prevents doubled '-g' options and combined '-g' and '-gstabs' options - depending on the particular Linux config being built, a compilation will have a single '-g' or a single '-gstabs' or neither of those options The Linux embedded builds doesn't support FDS yet so most of those compiles fall into the "neither" bucket... Thanks, in advance, for any reviews. DanLooks good to me. Makes it much clearer than the early version that DEBUG_BINARIES effectively overrides everything else.
