On 2012-09-14 15:54, David Holmes wrote:
Magnus,
This still looks okay to me. My main annoyance is the proliferation of
the condition check and the duplication. I know this has taken far too
much time already but it seems to me that we should be able to factor:
+ ifeq ($(TEST_IN_BUILD),true)
cd $(OSNAME)_$(BUILDARCH)_compiler2/$@ && ./test_gamma
+ endif
into a function so that we do:
$(eval $(call do-test-gamma, dir)
where we pass in the target specific directory. And of course the
function does nothing if TEST_IN_BUILD is not set.
Just a thought.
I'd rather not do that. The problem with duplication starts on an even
higher level -- we have three files that do basically the same thing,
and then in each of these, we have six stanzas that do basically the
same thing. Trying to remove the duplication in these stanzas, but
keeping the duplicate stanzas and the duplicate files is like the
proverbial porcine makeup. But it adds more risk to the fix, and I'll
have to re-run all testing.
/Magnus
