Alan seems to prefer explicit generation for this class. In that case the correct place to add it is in the list I referred to earlier:

in jdk/makefiles/CompileJavaClasses.gmk:

JDK_BASE_HEADER_CLASSES:=java.lang.Integer \
                         java.lang.Long \
                         java.net.SocketOptions \
                         sun.nio.ch.IOStatus \
java.io.FileSystem <- Add this and the backslash on the previous line

/Erik

On 2012-10-24 13:13, Alan Bateman wrote:
On 23/10/2012 19:47, Dan Xu wrote:
Thank you for all your good comments. After adding the @GenerateNativeHeader annotation, I am able to build the jdk using the new build.

But where can I check whether this class is part of the base module in jigsaw? Or should I just use the annotation as the concerns will go away soon?

-Dan
I think Erik or Magnus should be able to advise on where is the right place to explicitly generate the headers for the core classes. If there isn't any easy way to do that then I wouldn't object to adding @GenerateNativeHeader, on the assumption that it will be replaced soon.

-Alan.

Reply via email to